feat: fully support manual_ip, use_address, and domain YAML tags#5
Open
drothenberger wants to merge 1 commit into
Open
feat: fully support manual_ip, use_address, and domain YAML tags#5drothenberger wants to merge 1 commit into
drothenberger wants to merge 1 commit into
Conversation
Prior to this commit, the updated looked in the device YAML for a "manual_ip" tag and used that for the IP address of the device, if specified. If not, it fell back to mDNS, using "node.local." This did not work in cases where "use_address" or "domain" were specified in the YAML. It also did not work if these tags are included from another file and are not present directly in the device YAML. This commit fixes these issues in two ways: * It uses the `esphome config` command to get the complete YAML for the device, including any included files. This also removes comments that could have confused the previous implementation. * It looks for the "use_address" field first, then "manual_ip," and finally domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the updated looked in the device YAML for a "manual_ip" tag and used that for the IP address of the device, if specified. If not, it fell back to mDNS, using "node.local."
This did not work in cases where "use_address" or "domain" were specified in the YAML. It also did not work if these tags are included from another file and are not present directly in the device YAML.
This commit fixes these issues in two ways:
esphome configcommand to get the complete YAML for the device, including any included files. This also removes comments that could have confused the previous implementation.