Add honourary member endpoints#150
Merged
Merged
Conversation
jbriones1
requested changes
Jun 30, 2026
jbriones1
left a comment
jbriones1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, looks really good!
One thing that will need to change in many places is that "honourary" is less common than "honorary", even in Canada. That's my bad since that's how I wrote it in the issue. Please go through and change everything that says "honourary" to "honorary"
Contributor
Author
|
Done |
Contributor
Author
|
Fixed merge conflicts |
jbriones1
requested changes
Jul 3, 2026
jbriones1
left a comment
jbriones1
left a comment
Contributor
There was a problem hiding this comment.
Your patch looks great, but one project-specific things are missing.
src/load_test_db.py needs to import your table file to ensure the test database creates it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130
Summary:
Testing: