Skip to content

Feat docker file#159

Open
AnsonCheng03 wants to merge 10 commits into
developmentfrom
feat-docker-file
Open

Feat docker file#159
AnsonCheng03 wants to merge 10 commits into
developmentfrom
feat-docker-file

Conversation

@AnsonCheng03

Copy link
Copy Markdown
Collaborator

No description provided.

@AnsonCheng03 AnsonCheng03 added the feat New feature or request label May 2, 2024
@AnsonCheng03 AnsonCheng03 requested a review from isaackhlam June 13, 2024 16:30
image
? `https://beaconnect-image-imagebucket-ft90dpqhkbr1.s3.ap-southeast-1.amazonaws.com/${image}`
? `${
process.env.REACT_APP_IMAGE_VIEW_URL ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider REACT_APP_IMAGE_BUCKET_URL ?

body: base64Data,
})
fetch(
process.env.REACT_APP_IMAGE_SERVER_URL ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider REACT_APP_IMAGE_UPLOAD_URL ?


const httpLink = createHttpLink({
uri: 'https://h8e9hgszz8.execute-api.ap-southeast-1.amazonaws.com/Prod/graphql',
uri: process.env.REACT_APP_API_URL || 'https://h8e9hgszz8.execute-api.ap-southeast-1.amazonaws.com/Prod/graphql',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider REACT_APP_GRAPHQL_BACKEND_URL ?

data?.reBit?.author?.info?.image
? `https://beaconnect-image-imagebucket-ft90dpqhkbr1.s3.ap-southeast-1.amazonaws.com/${data?.reBit?.author?.info?.image}`
? `${
process.env.REACT_APP_IMAGE_VIEW_URL ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider REACT_APP_IMAGE_BUCKET_URL ?

data?.author?.info?.image
? `https://beaconnect-image-imagebucket-ft90dpqhkbr1.s3.ap-southeast-1.amazonaws.com/${data?.author?.info?.image}`
? `${
process.env.REACT_APP_IMAGE_VIEW_URL ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider REACT_APP_IMAGE_BUCKET_URL ?

profileDetails?.info?.image
? `https://beaconnect-image-imagebucket-ft90dpqhkbr1.s3.ap-southeast-1.amazonaws.com/${profileDetails?.info?.image}`
? `${
process.env.REACT_APP_IMAGE_VIEW_URL ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider REACT_APP_IMAGE_BUCKET_URL ?

userInfo?.info?.image
? `https://beaconnect-image-imagebucket-ft90dpqhkbr1.s3.ap-southeast-1.amazonaws.com/${userInfo?.info.image}`
? `${
process.env.REACT_APP_IMAGE_VIEW_URL ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider REACT_APP_IMAGE_BUCKET_URL ?

Comment thread docker-compose.yml
@@ -0,0 +1,53 @@
version: "3.8"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will raise warning for newer version of docker compose (In my case 2.27.1)
docker-compose.yml: version is obsolete

Comment thread docker-compose.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot build the the services using docker compose. Why do you want to use it ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants