Resolves issue #1666, Authenticate vs Authorize ordering on routes in controllers#1807
Open
afoote-mitre wants to merge 1 commit into
Open
Resolves issue #1666, Authenticate vs Authorize ordering on routes in controllers#1807afoote-mitre wants to merge 1 commit into
afoote-mitre wants to merge 1 commit into
Conversation
…g and Audit controllers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #1666
Summary
One route in both the Registry Org and Audit controllers was verifying if a user is authorized ( if they are secretariat) before authenticating the user. The order of these operations has been correctly flipped to ensure that the user is authenticated first, then evaluated for authority to call the route in question.
Important Changes
registry-org.controller/index.jsaudit.controller/index.jsTesting
Steps to manually test updated functionality, if possible
npm run test:integrationand ensure all tests pass as expected