Merged
Conversation
I ran tidal-Simmons and kpp tests on derecho, and copied the resulting .nc files into new baselines/ directory. I also copied MARBL's netcdf comparison tool into CVMix_tools/ and then updated run_test_suite.sh to (a) run the KPP test with the -nc flag, and compare the contents of each netcdf file to the baseline. Lastly, I updated the github action to make sure the python environment contains xarray, numpy, and netcdf4.
Add Bryan-Lewis baselines, and ensure data_memcopy.nc == data_pointer.nc
3 tasks
Bryan Lewis test was not writing netcdf files
Also update the test suite to compare against these new baselines
Contributor
Author
|
New test results: Test Results:
1. CodeConsistency.py: PASS
2. make allclean: PASS
3. make libcvmix.a: PASS
4. make cvmix.exe without netcdf: PASS
5. Bryan Lewis: PASS
6. Double Diffusion: PASS
7. Shear: PASS
8. KPP: PASS
9. make cvmix.exe with netcdf: PASS
10. Tidal (requires netCDF): PASS
+11. tidal-Simmons baseline comparison (single_col.nc): PASS
+12. Bryan Lewis (with netCDF): PASS
+13. Bryan-Lewis baseline comparison (data_memcopy.nc): PASS
+14. Bryan-Lewis baseline comparison (data_pointer.nc): PASS
+15. Bryan-Lewis memcopy and pointer comparison: PASS
+16. Double Diffusion (with netCDF): PASS
+17. double_diff baseline comparison (data.nc): PASS
+18. Shear (with netCDF): PASS
+19. shear baseline comparison (data_LMD.nc): PASS
+20. shear baseline comparison (data_PP1d.nc): PASS
+21. shear baseline comparison (data_PP2d.nc): PASS
+22. KPP (with netCDF): PASS
+23. kpp baseline comparison (test1.nc): PASS
+24. kpp baseline comparison (test3.nc): PASS
+25. kpp baseline comparison (test4a.nc): PASS
+26. kpp baseline comparison (test4b.nc): PASS
+27. kpp baseline comparison (test4c.nc): PASS
+28. kpp baseline comparison (test4d.nc): PASS
+29. kpp baseline comparison (test5.nc): PASS
+30. kpp baseline comparison (test7.nc): PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save netcdf baselines from all the tests, and make sure test suite does not change answers (if answer changes are expected, we can update the baseline)