Conversation
|
@awlx Would you mind to review? Blocky added in recent release support for DoQ. |
|
Oh nice! Will fully review on Thursday as I am currently on holiday. |
There was a problem hiding this comment.
Pull request overview
This PR adds DNS-over-QUIC (DoQ) support alongside existing DoH support by routing encrypted DNS through the local blocky proxy, and updates both the GUI DNS page and CLI to configure DoQ-capable upstreams.
Changes:
- Add DoQ upstream presets and a unified
BlockyModeabstraction for DoH/DoQ. - Update the DNS GUI to expose a DoQ toggle and a custom DoQ endpoint field, with mutual exclusion between DoT/DoH/DoQ.
- Update CLI handling and actions to use a unified
change_dns_server_blocky()path for encrypted DNS via blocky.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pages/dns.rs | Adds DoQ UI controls, custom DoQ endpoint handling, and blocky-mode-aware selection/application logic. |
| src/dns.rs | Introduces DoQ preset endpoints plus BlockyMode and helpers for reading/writing blocky upstreams. |
| src/cli_handler.rs | Extends DNS CLI flows to support DoQ and reuses shared blocky application helpers. |
| src/actions.rs | Replaces DoH-specific blocky application with a mode-aware blocky configuration/apply function. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Tested locally and everything looks correct and works as expected :). The DoQ toggle, mutual exclusion with DoT/DoH, custom endpoint field, and the unified blocky flow all behave properly. Only issue is what Copilot already flagged, the build fails because of missing English fallback strings in
Once those are in, it compiles and runs fine :). |
Add DoQ as an encrypted DNS mode alongside DoT and DoH, using blocky as a local proxy in the GUI and CLI. Include FFMUC in the provider list and English UI strings. Signed-off-by: Peter Jung <admin@ptr1337.dev>
Translation will be added after the current open Translation PRs are merged.
Signed-off-by: Peter Jung admin@ptr1337.dev