chore: update dependencies and fix eslint errors#11
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates runtime/dev dependencies and resolves ESLint/type issues introduced by the upgrades (continuation of #10).
Changes:
- Bumped a set of key dependencies (Next.js, React, Recharts, Tailwind, etc.) and regenerated
bun.lock. - Adjusted keyboard shortcut hooks to satisfy hook dependency/linting and simplify timer cleanup.
- Updated chart tooltip typing and minor UI lint suppressions/cleanup.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hooks/use-keyboard-shortcut-listener.ts | Refactors timer handling and adjusts hook dependencies for shortcut listeners. |
| src/components/ui/data-table.tsx | Adds an inline ESLint suppression for a hook-related rule. |
| src/components/ui/chart.tsx | Updates tooltip-related types and a React key usage. |
| src/components/charts.tsx | Aligns tooltip formatter function signatures with Recharts types. |
| src/app/dashboard/profile/page.tsx | Removes an unused React import to satisfy linting. |
| src/app/actions/stats.ts | Minor formatting cleanup in overload declarations. |
| src/app/actions/session.ts | Minor formatting cleanup in overload declarations. |
| package.json | Updates dependency versions across runtime and dev tooling. |
| bun.lock | Regenerates lockfile to reflect updated dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let timer: NodeJS.Timeout | null = null; | ||
|
|
||
| useEffect(() => { | ||
| let timer: NodeJS.Timeout | undefined; |
Comment on lines
+52
to
+55
| clearTimeout(timer); | ||
| } else { | ||
| colonPressed = false; | ||
| clearTimer(timer); | ||
| clearTimeout(timer); |
| return () => { | ||
| globalThis.removeEventListener('keydown', handleKeyDown); | ||
| clearTimer(timer); | ||
| clearTimeout(timer); |
| setRowSelection({}); | ||
| }, [resetSelection]); | ||
| const primarySearchFilterInputRef = React.useRef<HTMLInputElement>(null); | ||
| // eslint-disable-next-line react-hooks/incompatible-library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation for #10