fix(security): defense-in-depth hardening for plugin_syslog#303
Merged
TheWitness merged 5 commits intoCacti:developfrom Apr 9, 2026
Merged
fix(security): defense-in-depth hardening for plugin_syslog#303TheWitness merged 5 commits intoCacti:developfrom
TheWitness merged 5 commits intoCacti:developfrom
Conversation
Automated fixes: - XSS: escape request variables in HTML output - SQLi: convert string-concat queries to prepared statements - Deserialization: add allowed_classes=>false - Temp files: replace rand() with tempnam() Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the Syslog plugin’s security posture by hardening request-variable handling in the UI and adding automated static analysis via a CodeQL workflow.
Changes:
- Escapes request variables used in HTML
valueattributes insyslog.phpto reduce XSS risk. - Adds a GitHub Actions CodeQL workflow intended to run security analysis on pushes/PRs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
syslog.php |
Uses html_escape_request_var() for date/removal request vars rendered into HTML attributes. |
.github/workflows/codeql.yml |
Introduces a CodeQL workflow for automated security scanning. |
xmacan
approved these changes
Apr 9, 2026
xmacan
approved these changes
Apr 9, 2026
bmfmancini
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated defense-in-depth hardening addressing 51 security audit findings.
html_escape_request_var()rand()withtempnam()All changes are PHP 7.0+ compatible for Cacti 1.2.x.
Test plan