Fix print statements to echo in CI workflow and remove unit testing till ready#307
Merged
Fix print statements to echo in CI workflow and remove unit testing till ready#307
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow used to run Cacti + Syslog plugin CI, replacing non-portable shell print statements with echo so the workflow steps run reliably under bash.
Changes:
- Replaced
printwithechoin failure/logging blocks for the Cacti poller, Syslog poller, and log viewing step. - Removed a couple of stray blank lines in the workflow run block.
Removed the plugin regression tests step from the CI workflow.
TheWitness
changed the title
xmacan
approved these changes
Apr 9, 2026
xmacan
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.