Skip to content

Predefined timespan#309

Merged
TheWitness merged 3 commits intodevelopfrom
predefined-timespan
Apr 9, 2026
Merged

Predefined timespan#309
TheWitness merged 3 commits intodevelopfrom
predefined-timespan

Conversation

@TheWitness
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 9, 2026 20:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Syslog plugin’s time filtering to better support a “predefined timespan” vs. custom date range flow, including making “Custom” available as a selectable timespan and adjusting how span/shift/custom selections persist across requests.

Changes:

  • Refines syslog_request_validation() / set_shift_span() logic to distinguish predefined span (>0), shift, and custom date ranges, and to restore/compute date1/date2 accordingly.
  • Updates the timespan dropdown rendering to include “Custom” and to generate options by iterating the $graph_timespans map.
  • Adjusts main filter URL building and datetimepicker behavior in JS (adds seconds; switches timespan to “Custom” when dates are manually changed).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
syslog.php Updates request validation and span/shift/custom date handling; adjusts timespan dropdown generation.
js/functions.js Changes how filter URLs are built and improves datetimepicker behavior for custom ranges.

@TheWitness TheWitness merged commit 798c057 into develop Apr 9, 2026
8 checks passed
@TheWitness TheWitness deleted the predefined-timespan branch April 9, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants