Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Syslog plugin’s time filtering to better support a “predefined timespan” vs. custom date range flow, including making “Custom” available as a selectable timespan and adjusting how span/shift/custom selections persist across requests.
Changes:
- Refines
syslog_request_validation()/set_shift_span()logic to distinguish predefined span (>0), shift, and custom date ranges, and to restore/compute date1/date2 accordingly. - Updates the timespan dropdown rendering to include “Custom” and to generate options by iterating the
$graph_timespansmap. - Adjusts main filter URL building and datetimepicker behavior in JS (adds seconds; switches timespan to “Custom” when dates are manually changed).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
syslog.php |
Updates request validation and span/shift/custom date handling; adjusts timespan dropdown generation. |
js/functions.js |
Changes how filter URLs are built and improves datetimepicker behavior for custom ranges. |
netniV
approved these changes
Apr 9, 2026
xmacan
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.