Skip to content

refactor: safe PHP 7.4 modernization #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
somethingwithproof wants to merge 6 commits into from
Closed

refactor: safe PHP 7.4 modernization #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
002c1f0
refactor: add strict typing across syslog plugin
somethingwithproof Apr 9, 2026
4c37c35
refactor: safe PHP 7.4 modernization for syslog plugin
somethingwithproof Apr 9, 2026
2db1b7f
fix: Removing files in place that are not applicable
TheWitness Apr 10, 2026
e76166b
fix: Copilot review comment
TheWitness Apr 10, 2026
a297864
fix: More array conversion errors
TheWitness Apr 10, 2026
49f1725
fix: Fix up one unit test
TheWitness Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?php

declare(strict_types=1);
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
Expand Down Expand Up @@ -77,7 +79,7 @@ function syslog_db_execute($sql, $log = TRUE) {
*
* @return '1' for success, '0' for error
*/
function syslog_db_execute_prepared($sql, $parms = array(), $log = TRUE) {
function syslog_db_execute_prepared($sql, $parms = [], $log = TRUE) {
global $syslog_cnn;
return db_execute_prepared($sql, $parms, $log, $syslog_cnn);
}
Expand Down Expand Up @@ -108,7 +110,7 @@ function syslog_db_fetch_cell($sql, $col_name = '', $log = TRUE) {
*
* @return (bool) the output of the sql query as a single variable
*/
function syslog_db_fetch_cell_prepared($sql, $params = array(), $col_name = '', $log = TRUE) {
function syslog_db_fetch_cell_prepared($sql, $params = [], $col_name = '', $log = TRUE) {
global $syslog_cnn;
return db_fetch_cell_prepared($sql, $params, $col_name, $log, $syslog_cnn);
}
Expand All @@ -135,7 +137,7 @@ function syslog_db_fetch_row($sql, $log = TRUE) {
*
* @return the first row of the result as a hash
*/
function syslog_db_fetch_row_prepared($sql, $params = array(), $log = TRUE) {
function syslog_db_fetch_row_prepared($sql, $params = [], $log = TRUE) {
global $syslog_cnn;
return db_fetch_row_prepared($sql, $params, $log, $syslog_cnn);
}
Expand All @@ -162,7 +164,7 @@ function syslog_db_fetch_assoc($sql, $log = TRUE) {
*
* @return the entire result set as a multi-dimensional hash
*/
function syslog_db_fetch_assoc_prepared($sql, $params = array(), $log = TRUE) {
function syslog_db_fetch_assoc_prepared($sql, $params = [], $log = TRUE) {
global $syslog_cnn;
return db_fetch_assoc_prepared($sql, $params, $log, $syslog_cnn);
}
Expand Down
Loading