fix(util): tighten const usage and pthread format#454
Merged
netniV merged 2 commits intoCacti:developfrom Mar 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR follows up on warning cleanup by tightening read_spine_config’s API to accept an immutable file path and correcting a thread-id log format specifier to match the cast type.
Changes:
- Updated
read_spine_configto takeconst char *filein both the header and implementation. - Fixed
pthread_self()logging format specifier from%ldto%luto match the(unsigned long int)cast.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| util.h | Updates read_spine_config declaration to const char * for const-correctness. |
| util.c | Updates read_spine_config definition/docs to match header; fixes pthread_self() log prefix format specifier. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
somethingwithproof
force-pushed
the
fix/warnings-followup-pr
branch
from
83bb31f to
73259b2
Compare
Refs Cacti#452 Use const for read_spine_config file path. Use %lu for pthread_self logging cast. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/warnings-followup-pr
branch
from
73259b2 to
6df7449
Compare
5 tasks
TheWitness
approved these changes
Mar 12, 2026
netniV
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR for warning cleanup outside #452 scope.\n\nChanges:\n- make read_spine_config take a const file path in util.h and util.c\n- fix pthread_self log format specifier to match cast type (%lu)\n\nValidation:\n- change is minimal and isolated\n- local configure/build could not complete in this environment due missing MySQL headers
Linked issue
Fixes #464