test(revenue-pool): define empty batch_distribute behavior#198
Open
quickweb-stack wants to merge 1 commit intoCalloraOrg:mainfrom
Open
test(revenue-pool): define empty batch_distribute behavior#198quickweb-stack wants to merge 1 commit intoCalloraOrg:mainfrom
quickweb-stack wants to merge 1 commit intoCalloraOrg:mainfrom
Conversation
|
@quickweb-stack Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, Close: #198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #165
Implemented the behavior change in [lib.rs] and [test.rs] : batch_distribute now panics on an empty payments vector with batch_distribute requires at least one payment, matching the vault’s batch_deduct policy and making malformed admin batch jobs fail explicitly instead of silently no-oping. I also added a short doc note at [revenue-pool-batch-distribute.md].
cargo fmt --all completed successfully. The requested cargo clippy --all-targets --all-features -- -D warnings, cargo test, and cargo build --target wasm32-unknown-unknown --release -p callora-revenue-pool all failed for an environment reason, not a contract error: the machine is out of disk space. Get-PSDrive shows only about 0.01 GB free on C:, and Rust reported repeated no space on device / There is not enough space on the disk errors while compiling dependencies. Coverage is also blocked right now because cargo tarpaulin is not installed (error: no such command: tarpaulin).