test: require_auth coverage sweep across contracts#219
Merged
greatest0fallt1me merged 4 commits intoCalloraOrg:mainfrom Mar 31, 2026
Merged
test: require_auth coverage sweep across contracts#219greatest0fallt1me merged 4 commits intoCalloraOrg:mainfrom
greatest0fallt1me merged 4 commits intoCalloraOrg:mainfrom
Conversation
- Audited all privileged entrypoints in vault, revenue_pool, and settlement - Added negative require_auth tests to each crate's test.rs - Fixed pre-existing setup_contract missing third_party in settlement tests - Documented intentional exceptions: settlement::init and vault::require_owner - Updated SECURITY.md with audit findings and cross-references - All 180 tests pass Closes CalloraOrg#160
|
@Sam-Rytech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Audited all privileged entrypoints in vault, revenue_pool, and settlement - Added negative require_auth tests to each crate's test.rs - Fixed pre-existing setup_contract missing third_party in settlement tests - Documented intentional exceptions: settlement::init and vault::require_owner - Updated SECURITY.md with audit findings and cross-references - All 180 tests pass Closes CalloraOrg#160
Sam-Rytech
force-pushed
the
test/require-auth-sweep
branch
3 times, most recently
from
1a8bbb4 to
60c86eb
Compare
- Audited all privileged entrypoints in vault, revenue_pool, and settlement - Added negative require_auth tests to each crate's test.rs - Fixed pre-existing setup_contract missing third_party in settlement tests - Documented intentional exceptions: settlement::init and vault::require_owner - Updated SECURITY.md with audit findings and cross-references - All 180 tests pass Closes CalloraOrg#160
Sam-Rytech
force-pushed
the
test/require-auth-sweep
branch
from
60c86eb to
26075cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160