completed get article by id task, not sure on err handle#3
Open
completed get article by id task, not sure on err handle#3
Conversation
xmenbteam
suggested changes
Mar 28, 2022
| }); | ||
| test("400: invalid article", async () => { | ||
| const result = await request(app).get("/api/articles/99995").expect(400); | ||
| expect(result.body.msg).toBe("Bad request"); |
There was a problem hiding this comment.
So think about this... Is this a 400? It isn't an invalid article ID as it's a number, so should return a 404. You mentioned up there about returning an empty array - could you do something with that to reject the promise?
A 400 - bad request - would be eg an invalid data type like 'cheese'
| @@ -0,0 +1,13 @@ | |||
| const db = require("../db/connection"); | |||
|
|
|||
| exports.selectAllArticles = async (article_id) => { | |||
There was a problem hiding this comment.
This function should now no longer be called selectAllArticles - what should it be?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have successfully implemented func to return article by id on GET request. When trying to implement err handling the query in article.models did not throw an error despite being invalid id, instead returned an empty array. Let me know if I should implement the error handling differently to how I have here