Conversation
Rosem10
suggested changes
Mar 29, 2022
Rosem10
left a comment
Rosem10
left a comment
There was a problem hiding this comment.
Please add those couple of tests that I've outlined in the comments.
models/topics.models.js
Outdated
| exports.selectAllTopics = () => { | ||
| return db.query(`SELECT * FROM topics`).then((result) => { | ||
| return db.query(`SELECT * FROM topics;`).then((result) => { | ||
| console.log(result.rows); |
| }, | ||
| }); | ||
| }); | ||
| test("400: empty patch object returns bad request", async () => { |
There was a problem hiding this comment.
Please add a test for an article id of the wrong type - e.g. /api/articles/banana.
There was a problem hiding this comment.
Also for { inc_votes: banana } (again, wrong type)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successfully implemented patch votes by article id - handling for 404 and 400