Add workflow to catch broken URLs in the docs#356
Add workflow to catch broken URLs in the docs#356jatkinson1000 wants to merge 7 commits intomainfrom
Conversation
f9691de to
1760a89
Compare
|
Tried:
Will leave for now as non-urgent and taken a fair amount of time today. |
c4c1011 to
42622b0
Compare
90d3802 to
f7a113a
Compare
|
Made my own 🙄 Works fine on my machine, but fails on GitHub CI for the gcc links. Is Gnu blocking requests from GitHub servers?? 🤣 This was supposed to be simple 😭 |
|
Huh, updated but passed fine that time 🤷 |
253839d to
55a9f1a
Compare
|
TODO:
|
276e0a2 to
8e2f568
Compare
8e2f568 to
d17dab4
Compare
…ntication blocks.
|
@Mikolaj-A-Kowalski any thoughts appreciated here. This seems rather fickle (rate limiting and bots/redirects to be checked manually) to run as part of CI. Further, there are some links to TorchScript documentation that it seems PyTorch has simply deleted from the latest version. |
|
I would not be inclined to scrap the automated check completely (as in do we really trust ourselves to run the script as often as we should ;-) ), but I completely agree that it is far to brittle to be blocking for the CI. What I am thinking is we could add Also to make the results more visible we can raise a 'notice' using the appropriate workflow command, i.e. for the failure echo something like that: This should create a helpful (?) banner. Not entirely sure where though if the file and line is not explicitly specified... May also be a better idea to collect all failing links into a single message to avoid getting multiple banners. My thinking is that we can keep the check running for some time and we will get a sense of how annoying vs useful it will be. If it creates too much noise we can always scrap it. |
joewallwork
left a comment
There was a problem hiding this comment.
This version of the script mostly works well for me, although I get the rate limit errors mentioned.
I'm wondering if we just add it as a script and rely on developers to run instead as a useful utility
How about we add it as a CI job whose only trigger is calendar-based? e.g., runs early AM on the first day of the month?
| chmod +x checklinks.sh | ||
| ./checklinks.sh |
There was a problem hiding this comment.
Is it bad practice to ship scripts that are already executable?
Spotted by @niccolozanotti and patched here.
I also did a quick scan for anything else that may be outdated.