Unittest ftorch_utils Python module#563
Merged
joewallwork merged 96 commits intomainfrom Mar 26, 2026
Merged
Conversation
* Fix Windows CI: pass venv Python executable to CMake * Consistent capitalisation --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joewallwork <22053413+joewallwork@users.noreply.github.com>
Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com>
jatkinson1000
approved these changes
Mar 25, 2026
Member
jatkinson1000
left a comment
jatkinson1000
left a comment
There was a problem hiding this comment.
Thanks @joewallwork the restructuring is good.
Approving as there's noting major that needs changing as I see it, but there are some suggestions for consideration before you do.
- Perhaps rename path
test/pythontotest/ftorch_utilsto be clear what these tests apply to? Or place tests insideftorch_utilsbut I think flat is better here. - Rename some tests to make the intent clearer, this might just be to me if you disagree
- Couple of other small points for you to consider
Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com>
Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| cmake --install build | ||
|
|
||
| - name: Run Python unit tests | ||
| shell: cmd |
Check notice
Code scanning / zizmor
usage of GitHub Actions misfeatures Note test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides unit tests for the Python module added in that PR. Some of the functionality from the script is separated out into different modules to make the code more amenable to unit testing.
I propose that the
main_clifunction doesn't get unit tested. This should be fine so long as all of its components have unit tests because the examples provide integration tests.