[codex] Add Capacitor SPM product alias - #18
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Beta npm buildMaintainers can publish this PR to npm for fast testing. Comment The workflow will:
Security note: beta publish is only enabled for branches inside this repository. |
|
Warning Review limit reached
Your plan currently allows 2 reviews/hour. Refill in 24 minutes. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR fixes iOS SwiftPM product naming consistency by updating Package.swift product declarations, upgrading the capacitor-swift-pm dependency to 8.3.4, and enhancing the plugin wiring validation script to automatically derive and verify product names from package.json conventions. ChangesiOS SwiftPM Product Naming Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/check-capacitor-plugin-wiring.mjs`:
- Around line 207-214: Guard calls to packageNameToSpmProductName by verifying
the package object has a valid name string before deriving the SPM product;
specifically, check that pkg && typeof pkg.name === "string" (or similar) and
report a wiring error or skip processing when missing instead of calling
packageNameToSpmProductName, and apply the same guard to the other call site
that currently invokes packageNameToSpmProductName (the second occurrence in
this file) so the script no longer throws when package.json lacks a name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3c3b3a7a-eef9-4965-b4dc-848d947e7253
📒 Files selected for processing (3)
Package.resolvedPackage.swiftscripts/check-capacitor-plugin-wiring.mjs
8747114 to
bd8de0f
Compare
bd8de0f to
70ea461
Compare
What
CapgoCapacitorAudioSessionSwiftPM library product alias while keeping the existingCapgoCapacitorPluginAudioSessionproduct.example-app/fixture.Package.resolvedto the Capacitor 8 SwiftPM package selected by the existingfrom: "8.0.0"requirement.Why
CapgoCapacitorAudioSessionfor@capgo/capacitor-audio-session.CapgoCapacitorPluginAudioSession, so host apps could fail during Xcode package resolution.How
.libraryproduct that points to the existingAudioSessionPlugintarget.package.jsonin the wiring script and fail when it is missing..github/scripts/verify-packed-example.sh.Testing
bun run check:wiringswift package describe --type jsonbun run fmtbun run lintbun run verify:webbun run verify:iosJAVA_HOME=/opt/homebrew/opt/openjdk@21 ANDROID_HOME=$HOME/Library/Android/sdk ANDROID_SDK_ROOT=$HOME/Library/Android/sdk PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH bun run verify:androidbash ./.github/scripts/verify-packed-example.sh webbash ./.github/scripts/verify-packed-example.sh iosJAVA_HOME=/opt/homebrew/opt/openjdk@21 ANDROID_HOME=$HOME/Library/Android/sdk ANDROID_SDK_ROOT=$HOME/Library/Android/sdk PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH bash ./.github/scripts/verify-packed-example.sh androidNot Tested