fix(android): propagate IME inset and force bottom inset on Android 1… - #643
fix(android): propagate IME inset and force bottom inset on Android 1…#643rencsikmarian wants to merge 1 commit into
Conversation
Beta npm buildThis PR comes from a fork, so beta publish is disabled for security. If you need a beta package, move the branch into this repository first. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe Android inset flow now combines safe-area and IME bottom insets, applies bottom insets for opted-in or forced edge-to-edge containers, and adds coverage for keyboard, clamping, and Android 15 behavior. ChangesAndroid container insets
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WebViewDialog
participant WindowInsetsCompat
participant SafeAreaInsetsSupport
participant WebViewContainer
WebViewDialog->>WindowInsetsCompat: Read IME insets
WebViewDialog->>SafeAreaInsetsSupport: Determine bottom inset policy
SafeAreaInsetsSupport-->>WebViewDialog: Return applyBottomInset
WebViewDialog->>SafeAreaInsetsSupport: Resolve safe bottom, IME, and app-bar padding
SafeAreaInsetsSupport-->>WebViewDialog: Return container bottom padding
WebViewDialog->>WebViewContainer: Apply bottom padding
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.44.1)android/src/main/java/ee/forgr/capacitor_inappbrowser/WebViewDialog.javaast-grep timed out on this file Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…5 edge-to-edge Follow-up to Cap-go#642. Applies the keyboard (IME) inset to the SwipeRefreshLayout container padding (child margins are ignored there) and, on Android 15 edge-to-edge, insets the bottom system bar regardless of the enabledSafeBottomMargin opt-in. Refs Cap-go#641.
79ba043 to
157c39f
Compare
|



…5 edge-to-edge
Follow-up to #642. Applies the keyboard (IME) inset to the SwipeRefreshLayout container padding (child margins are ignored there) and, on Android 15 edge-to-edge, insets the bottom system bar regardless of the enabledSafeBottomMargin opt-in. Refs #641.
Summary by CodeRabbit