security: CLI security audit — 6 exploitable vulnerability findings - #104
Draft
cursor[bot] wants to merge 1 commit into
Draft
security: CLI security audit — 6 exploitable vulnerability findings#104cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…dings Findings: 1. HIGH: Arbitrary command execution via hook scripts (common.ts) 2. HIGH: Path traversal in Cordova plugin asset copying (cordova.ts) 3. MEDIUM: XML injection in generated config files (cordova.ts) 4. MEDIUM: Unvalidated platform path config enables out-of-project writes 5. MEDIUM: Symlink following in web asset copy operations 6. LOW-MEDIUM: Gradle flavor injection in build arguments Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
Beta npm buildMaintainers can publish one Capacitor Plus workspace package from this PR to npm for fast testing. Comment Examples: /publish-beta core
/publish-beta cli
/publish-beta @capacitor-plus/coreIf exactly one workspace package changed, Packages:
The workflow will:
Security note: beta publish is only enabled for branches inside this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cli/src/) documenting 6 exploitable vulnerabilities with complete attack chains.Why
How
Findings Summary
common.ts:160-206cordova.ts:138,android/update.ts:344cordova.ts:207-239config.ts:211-212, 267-268copy.ts:183-186android/build.ts:14Testing
Not Tested
fs-extra.copydefaults have changed in newer versions regarding symlink behavior.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.