Adventure Mode: Internationalization groundwork + Spanish Shandalar localization - #11621
Open
churrufli wants to merge 1 commit into
Open
Adventure Mode: Internationalization groundwork + Spanish Shandalar localization#11621churrufli wants to merge 1 commit into
churrufli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lays the groundwork for translating Adventure Mode by localizing the pieces that don't require any new infrastructure:
NewGameScene,AdventureQuestController,SettingsScene,EventScene,DuelScene,AdventureEventData,EffectData,AdventureQuestData) to the existingLocalizer/.propertiessystem. Keys added to all 10res/languages/*.propertiesfiles: real Spanish ines-ES, English placeholder elsewhere.quests-es-ES.json,shops-es-ES.json), using a per-language file mechanism that already exists inConfig.getFile()but was unused anywhere in the repo:quests.jsonis transparently replaced byquests-es-ES.jsonwhen the UI language ises-ES, with automatic fallback to the English file otherwise. This is the first real use of that per-language file mechanism anywhere in the repo — it existed inConfig.getFile()but nothing exercised it before this PR. Any other world or language can follow the same pattern going forward without further engineering work. No Java changes needed for this part, no changes to the English source files.forge-gui/tools/checkAdventureTranslations.py, a standalone script that diffs a world's English data files against their translations and reports entries that are missing, orphaned, or structurally out of sync (e.g. a new quest added only in English becomes entirely invisible toes-ESplayers, not just untranslated — this script catches that before it ships). Purely opt-in tooling for maintains a translation going forward.Scope
Only Shandalar (the default/flagship world) is covered. Other worlds and the NPC dialogue embedded in
.tmxmap files are a separate, larger piece of work and are intentionally not part of this PR.NPC dialogue embedded in
.tmxmap files is loaded through a different code path (Config.getFilePath()/getCommonFilePath()) that doesn't go through the language-fallback mechanism used here, so translating it needs its own design — left for a follow-up PR.