Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

added how to report errors back to the academy footer for lesson pages - #304

Open
csobier wants to merge 5 commits into
masterfrom
303-how-to-report-errors
Open

added how to report errors back to the academy footer for lesson pages#304
csobier wants to merge 5 commits into
masterfrom
303-how-to-report-errors

Conversation

@csobier

@csobier csobier commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

For issue #303. View any of the lesson pages, as shown in this staging envn: http://303-how-to-report-errors.academy.cartodb-staging.com/courses/beginners-course/getting-started/

@ohasselblad , @carlostallon , please approve .

@csobier

csobier commented Apr 4, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for the suggestion @ohasselblad , I moved this error text above the footer buttons to keep the spacing intact. Click any lesson page from this staging link to test: http://303-how-to-report-errors.academy.cartodb-staging.com/

@andy-esch

Copy link
Copy Markdown
Contributor

content looks good to me. for the design, the vertical space between the rules is different, so @carlostallon may want to take a look:

screen shot 2016-04-08 at 08 57 37

@andy-esch

Copy link
Copy Markdown
Contributor

@carlostallon, could you take a quick look at this to make sure the alignment (margins, etc.) are correct?

@carlostallon

Copy link
Copy Markdown

Sure guys,

This is my proposal:
image

Let me know if do you need help to implement it ;)

Thanks @ohasselblad and @csobier

@andy-esch

Copy link
Copy Markdown
Contributor

@carlostallon, love the proposal :) Could you help us implement it?

@carlostallon

Copy link
Copy Markdown

Of course @ohasselblad

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants