adds stride_view to cmcstl2#327
Open
cjdb wants to merge 1 commit intoCaseyCarter:masterfrom
cjdb:stride_view
Open
adds stride_view to cmcstl2#327cjdb wants to merge 1 commit intoCaseyCarter:masterfrom cjdb:stride_view
cjdb wants to merge 1 commit intoCaseyCarter:masterfrom
cjdb:stride_view
Conversation
cjdb
commented
Aug 18, 2019
|
|
||
| parent_t* parent_ = nullptr; | ||
| iterator_t<base_t> current_{}; | ||
| range_difference_t<base_t> step_{}; |
Collaborator
Author
There was a problem hiding this comment.
This should be a non_propagating_cache, but I've been having difficulty getting it to hold its value.
include/stl2/view/stride.hpp
Outdated
| } // namespace ext | ||
|
|
||
| namespace views::ext { | ||
| struct __stride_fn : detail::__pipeable<__stride_fn> { |
Collaborator
Author
There was a problem hiding this comment.
Apparently it's not necessary to derive from detail::__pipeable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stride_view is one of the things I regret not getting into C++20, so much so, that I'm planning on:
filter_viewas an ad-hocstride;