Fix Expert panel output clamped to 80 columns#66
Merged
Conversation
tmux sessions were created without `window-size manual`, so detached windows stayed at `default-size` (80x24). `resize_pane` also issued `tmux resize-pane`, which cannot grow a single-pane detached window. Set `window-size manual` in `create_session` and switch the resize implementation to `tmux resize-window` (requires tmux >= 2.9). Add a gated integration test that spawns real tmux and asserts the window actually resizes.
Satisfies clippy 1.95's unnecessary_sort_by check; DateTime<Utc> is Copy, so sort_by_key avoids the unneeded closure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TmuxManager::create_sessionnow setswindow-size manualon the session so detached windows no longer get auto-clamped todefault-size(80x24).TmuxManager::resize_panenow shells out totmux resize-windowinstead oftmux resize-pane; the latter cannot grow a single-pane detached window, so the previous implementation was a silent no-op.#[ignore]-gated integration test that spawns real tmux, callsresize_pane(0, 160, 40), and asserts the window actually reports160x40. ASessionGuardensures the test session is always killed even if an assertion panics.Why
The Expert panel displayed Claude output at a fixed ~80 columns regardless of the TUI panel's width. Root cause: tmux's default
window-size latestplus theresize-panesubcommand both silently reject resize requests under macot's detached-single-pane setup. Verified with live tmux reproduction.Test plan
make ci(813 passed, 1 ignored)cargo test --lib resize_pane_actually_grows_window_with_real_tmux -- --ignored --nocapture(1 passed)tmux list-panes -t <macot>:0 -F '#{window_width}x#{window_height}'tracks the panel width within ~250 msCompatibility
Requires tmux >= 2.9 (
resize-windowsubcommand). Documented in CHANGELOG.