Add mouse wheel scrolling to Expert Panel#67
Merged
Conversation
Extend the Event::Mouse dispatcher to route ScrollUp/ScrollDown events to a new handle_mouse_wheel helper. Wheel up over the panel enters scroll mode on the first tick (via capture_full_history, mirroring PageUp), then advances scroll_offset by WHEEL_SCROLL_LINES=3 per tick. Wheel down scrolls forward and re-enables auto-scroll at the bottom. Wheel events are suppressed when modals own the screen (help, role selector, report Detail view) and when the cursor is outside the panel rect. Focus is preserved — wheel events do not call set_focus. Add 7 property tests covering hit-test scope, direction, focus preservation, and modal/hidden-panel suppression.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MouseEventKind::ScrollUp/ScrollDownover the Expert Panel rect to a newhandle_mouse_wheelhelper; first wheel-up enters scroll mode viacapture_full_history(mirroringPageUp), subsequent ticks advancescroll_offsetbyWHEEL_SCROLL_LINES = 3. Wheel down re-enables auto-scroll at the bottom.set_focus.src/tower/app.rs::testscovering hit-test scope, direction, focus preservation, and modal/hidden-panel suppression.Includes pre-existing branch commit
4908e16(remove pending status write-back after expert exit).Design:
.macot/specs/expert-panel-mouse-wheel-scroll-design.mdTasks:
.macot/specs/expert-panel-mouse-wheel-scroll-tasks.mdTest plan
make ci— 820 tests passed, clippy clean under-D warnings, fmt-check green[SCROLL MODE],[N/M]indicator moves, wheel down re-pins at bottomTaskInput/ help modal open → no panel state change (focus preservation, modal suppression)ScrollUp/ScrollDownevents are emitted