Sync expert registries on worktree return#69
Merged
Conversation
return_expert_from_worktree previously cleared the persisted ExpertContext but left ExpertRegistry (main and router) holding the stale worktree_path. MessageRouter's worktree affinity check then rejected cross-expert messages for experts that had both returned to the project root, silently retrying until MAX_DELIVERY_ATTEMPTS. Extract clear_expert_worktree_state to reset context, both registries, and the on-disk manifest in one place, and call it from the return path so it mirrors the launch path (poll_worktree_launch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return_expert_from_worktreeclearedExpertContextbut leftExpertRegistry(main + router) holding the staleworktree_path.MessageRouter's worktree affinity check then rejected cross-expert messages for experts that had both returned to the project root, silently retrying untilMAX_DELIVERY_ATTEMPTS.clear_expert_worktree_stateto reset context, both registries, and the on-disk manifest in one place, and call it from the return path so it mirrors the launch path (poll_worktree_launch).Test plan
make ciMAX_DELIVERY_ATTEMPTSretries)