Prefer exact matches over partial matches in link resolution#18
Closed
Copilot wants to merge 4 commits into
Closed
Prefer exact matches over partial matches in link resolution#18Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Co-authored-by: Cassin01 <42632201+Cassin01@users.noreply.github.com>
…timestamps Co-authored-by: Cassin01 <42632201+Cassin01@users.noreply.github.com>
Co-authored-by: Cassin01 <42632201+Cassin01@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update file naming convention to include full path
Prefer exact matches over partial matches in link resolution
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple memos share similar titles (e.g.,
20260117_120000_meeting.mdand20260118_150000_important-meeting.md), the link resolver could match the wrong file due to partial matching taking precedence over exact matches.Changes
Link matching logic (
fnl/sm/links.fnl,lua/sm/links.lua)find_memo_by_partial()from single-pass OR logic to two-pass matchingTests (
fnl/sm/links_test.fnl,lua/sm/links_test.lua)Documentation (
README.md)[[20260117_143052_meeting-notes]]Behavior
This ensures
[[20260117_120000_meeting]]matches exactly instead of returning the first partial match likeimportant-meeting.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https fnl/sm/git_test.fnl fnl/sm/init.fnl fnl/sm/init_test.fnl fnl/sm/links.fnl fnl/sm/links_test.fnl fnl/sm/memo.fnl fnl/sm/memo_test.fnl fnl/sm/meta.fnl fnl/sm/meta_test.fnl fnl/sm/state.fnl fnl/sm/state_test.fnl(dns block)fennel-lang.org/usr/bin/wget wget -q REDACTED -O /tmp/fennel(dns block)/usr/bin/curl curl -L -o /tmp/fennel REDACTED(dns block)luarocks.org/usr/bin/lua5.3 /usr/bin/lua5.3 /usr/bin/luarocks install --local fennel(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.