Some optimizations #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al data in memory Avoids unnecessary save/load cycles
Fix pickle issue for multiprocessing
remlapmot
force-pushed
the
suggestions
branch
from
56c5283 to
400971c
Compare
ryan-odea
reviewed
Jan 26, 2026
Member
ryan-odea
left a comment
ryan-odea
left a comment
There was a problem hiding this comment.
This looks good! Also simplifies the code quite a bit - especially in the masking area
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ryan-odea
I believe these should give some speed ups.
I have bumped the version to 0.12.0 (hope that's ok).
You need pandas >= 3.0.0 installed for the warnings filter the pyproject.toml to work (might get error if still on pandas 2.#.#).(I removed the warnings filter - couldn't make it work - all the warnings are because the lifelines package generates them with the new pandoc 3.0.0., i.e., basically we can ignore them - they're for the lifelines package to fix.)