Closes #3207: Fix assign role email for collection sent twice#3208
Merged
Closes #3207: Fix assign role email for collection sent twice#3208
Conversation
sniewczas
approved these changes
Feb 11, 2026
...chive-webapp/src/main/java/edu/harvard/iq/dataverse/permission/ManagePermissionsService.java
Outdated
Show resolved
Hide resolved
...chive-webapp/src/main/java/edu/harvard/iq/dataverse/permission/ManagePermissionsService.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sylwester Niewczas <sniewcza@icm.edu.pl>
Collaborator
Author
|
I forgot to run the integration tests - and it turned out to not pass. So I've corrected it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem occurred because of the mismatch in conditions used in
PublishDataverseCommadandManagePermissionsService.I've changed the condition a little bit. The only reason why we should not send notification to user about assigned role is when the user do not have the ability to see the collection (url to collection is inside the email). That is when collection is unpublished and the user do not have a permission to view unpublished collection.
In such cases we postpone sending the notification until the collection is published.