Conversation
Push changes to master
Logic tests
kshomper
left a comment
There was a problem hiding this comment.
@JoeHCQ1 There are too many changes for me to evaluate them entirely; however, I trust your judgement and would like not to be a bottleneck to the activity. I also want to convey my appreciation also to @ArenM and @HRahikainen for their contributions, particularly the efforts to make CedarLogic cross platform.
|
@JoeHCQ1 I have read through your comments and recommendation. Thank you for summarizing them so effectively. |
It's imposible to run cmake -B build -A Win32 from VS developer command prompt, it gives me an error when try to download wxWidgets. I have installed and compiled wxWidgets manually and the error continues. Please, give better instructions to build, last version instructions was fine. |
|
@casanova-uja could you provided the error it gave you? It works fine for me, it's possible I set something else up and then forgot about it though. |
More information in issue catchorg/Catch2#2712 on GitHub.
Update Catch2 to fix build issues
|
@kshomper if you can click the green "approve" button I'll get these changes merged in and turn towards resolving bugs. (As I contributed code I can't click the green |
|
Joe ... As requested. Thanks for all your oversight on this. Keith |
|
Approved as requested. Keith
…On Mon, Mar 4, 2024 at 12:15 PM Joseph Richardson ***@***.***> wrote:
@kshomper <https://github.com/kshomper> if you can click the green
"approve" button I'll get these changes merged in and turn towards
resolving bugs. (As I contributed code I can't click the green approve
button)
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOTDQRXNSVQ3AEC5XCU5ETYWST2TAVCNFSM6AAAAAARTUAHVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGA4DCMZQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Dr. Keith Shomper*
Senior Professor of Computer Science and Cyber Operations
School of Engineering and Computer Science
Cedarville University <http://www.cedarville.edu>
PH: (937) 766-3786
|
|
I recently stumbled across this PR while attempting to modify the CedarLogic codebase. The build on the main branch seems to be broken and this PR works (at least on my Linux machine and my roommate's Windows machine), so it would be appreciated to merge the PR if it is ready. |

@kshomper, this PR has all the work from the last year. I realize this is a horribly non-agile way to do this, but for some reason me a year ago wanted to batch changes.
Here are the main changes/additions/improvements:
Much of this code is thanks to @ArenM and @HRahikainen.