Document expanded sandbox port publishing - #38
Conversation
📝 WalkthroughWalkthroughPublished application port guidance now consistently specifies ports 1024–65535 across the CLI, SDK docstrings, and README. The README also states the four-public-port limit and reservation of Celesto system ports. ChangesPublished port range
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/celesto/sdk/client.py (1)
1031-1031: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winWrap the expanded docstring line, mate.
This newly added text exceeds Ruff’s default line width. Keep the Google-style
Argsentry readable by splitting it across two lines.Proposed adjustment
- port: Application port to publish (1024-65535). Each computer supports up to four public ports. + port: Application port to publish (1024-65535). Each computer + supports up to four public ports.As per coding guidelines, Python code must use Ruff formatting and Ruff-default line length.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/celesto/sdk/client.py` at line 1031, Wrap the `port` argument description in the relevant Google-style docstring across two lines so it conforms to Ruff’s default line length while preserving the existing wording and documentation structure.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/celesto/sdk/client.py`:
- Line 1031: Wrap the `port` argument description in the relevant Google-style
docstring across two lines so it conforms to Ruff’s default line length while
preserving the existing wording and documentation structure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 64327b5c-9d45-43b6-8bed-dcc1faba4797
📒 Files selected for processing (3)
README.mdsrc/celesto/computer.pysrc/celesto/sdk/client.py
Summary
Tests
uv run ruff check src/celesto/sdk/client.py src/celesto/computer.pyuv run pytest -q tests/test_sdk.py tests/test_computer_cli.pyRelated pull requests
Summary by CodeRabbit