Skip to content

Document expanded sandbox port publishing - #38

Merged
aniketmaurya merged 1 commit into
mainfrom
feat/sandbox-port-publishing
Jul 28, 2026
Merged

Document expanded sandbox port publishing#38
aniketmaurya merged 1 commit into
mainfrom
feat/sandbox-port-publishing

Conversation

@aniketmaurya

@aniketmaurya aniketmaurya commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • document support for application ports from 1024 through 65535
  • document the four-active-port limit and Celesto-reserved ports
  • update Python API docstrings and CLI option help

Tests

  • uv run ruff check src/celesto/sdk/client.py src/celesto/computer.py
  • uv run pytest -q tests/test_sdk.py tests/test_computer_cli.py

Related pull requests

Summary by CodeRabbit

  • Documentation
    • Clarified that published application ports must be between 1024 and 65535.
    • Documented the limit of four public ports per computer, with system ports reserved.
    • Updated command-line help and SDK documentation to reflect the supported port range.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Published application port guidance now consistently specifies ports 1024–65535 across the CLI, SDK docstrings, and README. The README also states the four-public-port limit and reservation of Celesto system ports.

Changes

Published port range

Layer / File(s) Summary
Align port range guidance
src/celesto/computer.py, src/celesto/sdk/client.py, README.md
CLI option help and SDK parameter documentation now specify the 1024–65535 application port range. README guidance also documents up to four public ports per computer and reserved system ports.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • CelestoAI/sdk#16: Introduced the related computer port publish and unpublish commands and SDK methods.

Poem

Ports in line, from 1024 to the sky,
Four may sail, while system ports lie nigh.
The CLI speaks clear, the SDK agrees,
README keeps the rules with ease.
Sorted, shelby—no loose ends on these.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: documenting expanded sandbox port publishing support.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/sandbox-port-publishing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aniketmaurya
aniketmaurya merged commit ae526ed into main Jul 28, 2026
7 of 8 checks passed
@aniketmaurya
aniketmaurya deleted the feat/sandbox-port-publishing branch July 28, 2026 16:46

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/celesto/sdk/client.py (1)

1031-1031: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Wrap the expanded docstring line, mate.

This newly added text exceeds Ruff’s default line width. Keep the Google-style Args entry readable by splitting it across two lines.

Proposed adjustment
-            port: Application port to publish (1024-65535). Each computer supports up to four public ports.
+            port: Application port to publish (1024-65535). Each computer
+                supports up to four public ports.

As per coding guidelines, Python code must use Ruff formatting and Ruff-default line length.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/celesto/sdk/client.py` at line 1031, Wrap the `port` argument description
in the relevant Google-style docstring across two lines so it conforms to Ruff’s
default line length while preserving the existing wording and documentation
structure.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/celesto/sdk/client.py`:
- Line 1031: Wrap the `port` argument description in the relevant Google-style
docstring across two lines so it conforms to Ruff’s default line length while
preserving the existing wording and documentation structure.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 64327b5c-9d45-43b6-8bed-dcc1faba4797

📥 Commits

Reviewing files that changed from the base of the PR and between 998326d and f77fcde.

📒 Files selected for processing (3)
  • README.md
  • src/celesto/computer.py
  • src/celesto/sdk/client.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant