Change canonical reference delimiter from ":" to "." for manuscript formatting#296
Draft
Copilot wants to merge 2 commits into
Draft
Change canonical reference delimiter from ":" to "." for manuscript formatting#296Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: cubap <1119165+cubap@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update default separator for canonical reference
Change canonical reference delimiter from ":" to "." for manuscript formatting
Nov 17, 2025
cubap
requested changes
Nov 17, 2025
| if(!doc && (section && subsection)) doc = "Matthew" | ||
|
|
||
| if(doc && section && subsection) canonicalReference = `${doc} ${section}:${subsection}` | ||
| if(doc && section && subsection) canonicalReference = `${doc} ${section}.${subsection}` |
Member
There was a problem hiding this comment.
only reassign canonicalReference if it doesn't already have a value. This whole block can be put inside an if
Member
There was a problem hiding this comment.
We don't need this test. The tests here are weak and will be handled separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manuscripts typically use "." as the section delimiter (e.g., "Sententiae liber 2.dist. 17") rather than ":" which is primarily for biblical references. When building canonical references from structured fields (Document, Section, Subsection), the system was hardcoded to use ":".
Changes
modifyTableTR()injs/deer-config.jsto use "." delimiter when constructing canonical references from structured fieldsBehavior
Before:
After:
User-entered canonical reference strings (e.g., "Matthew 5:1") are preserved as-is. The structured fields are primarily for filtering/searching and only used to build the reference when no user input exists.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.