[ENG-9703] Feature/add new es8 metrics#11672
Merged
aaxelb merged 31 commits intoCenterForOpenScience:feature/9691-osfmetrics-migrationfrom Apr 15, 2026
Merged
[ENG-9703] Feature/add new es8 metrics#11672aaxelb merged 31 commits intoCenterForOpenScience:feature/9691-osfmetrics-migrationfrom
aaxelb merged 31 commits intoCenterForOpenScience:feature/9691-osfmetrics-migrationfrom
Conversation
aaxelb
requested changes
Apr 6, 2026
Contributor
aaxelb
left a comment
aaxelb
left a comment
There was a problem hiding this comment.
a few points clarifying intent for these migration targets
also, mind importing (at least something from) this file in osf/metrics/__init__.py and adding one or two smoke-tests to verify the index(templat)es are usable?
- use elasticsearch_metrics.test.util - move "Es8" prefix to suffix - autofill fields on `save`, not `__init__` (to work with how esdsl loads search results)
aaxelb
approved these changes
Apr 14, 2026
Contributor
aaxelb
left a comment
aaxelb
left a comment
There was a problem hiding this comment.
pushed some changes myself (seemed easier to express myself in code than text) -- pls approve if they seem good to you @bodintsov
- added tests that save/fetch es8
- ...which exposed some djelme bugs; updated dep to CenterForOpenScience/django-elasticsearch-metrics#96
- couldn't connect to local
elasticsearch8as configured; simplifieddocker-compose.yml - deduplicated gh actions services; replaced shell script with health check
- (matter of taste) moved
Es8prefix to suffix ones8_metricsrecord types
aaxelb
merged commit 6c45a66
into
CenterForOpenScience:feature/9691-osfmetrics-migration
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-9703
Purpose
Add new es8 metrics
Changes
Added new es8 metrics
Side Effects
TBD
QE Notes
TBD
CE Notes
TBD
Documentation
TBD