Make Reinterop skip attributes with 'Ignore' attribute#665
Merged
david-lively merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
david-lively
approved these changes
Feb 26, 2026
Contributor
david-lively
left a comment
There was a problem hiding this comment.
Short and simple. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR supports #656 and enables the use of Unity's
Color32struct with Reinterop.As @kring discovered,
Color32has anintfield that doesn't actually contribute to the struct's size. Reinterop was turning this into an actualintfield, preventing the actualr,getc. bytes from storing value.The easiest way to avoid this is to tell Reinterop to ignore anything with that
Ignoreattribute. It hasn't resulted in any surprises in any other generated classes; I checked with diff tools.Testing plan
dotnet publish Reinterop~ -o .before opening Unity.Color32 color = new Color32(0, 0, 0, 1)to Reinteropnative~/generated-Editor/include/DotNet/UnityEngine/Color32.h.r,g,b,andafields show up, but not an int32rgbafield.