fix: clean up showsUpdated on entity removal in ground batches (#9370)#13366
Open
chalabi2 wants to merge 3 commits intoCesiumGS:mainfrom
Open
fix: clean up showsUpdated on entity removal in ground batches (#9370)#13366chalabi2 wants to merge 3 commits intoCesiumGS:mainfrom
chalabi2 wants to merge 3 commits intoCesiumGS:mainfrom
Conversation
Contributor
|
Thank you for the pull request, @chalabi2! ✅ We can confirm we have a CLA on file for you. |
…mGS#9370) When an entity's `isShowing` changes, the updater is queued in `showsUpdated`. `Batch.prototype.remove` did not clean up this collection, leaving stale entries that cause `updateShows` to crash with "Cannot read properties of undefined (reading 'id')" on the next render frame. Add `this.showsUpdated.remove(id)` to `Batch.prototype.remove` in both `StaticGroundPolylinePerMaterialBatch` and `StaticGroundGeometryPerMaterialBatch`, consistent with existing cleanup for `subscriptions` and `updatersWithAttributes`. Fixes CesiumGS#9370
chalabi2
force-pushed
the
fix/stale-shows-updated-on-entity-removal
branch
from
825212a to
2749cd9
Compare
Author
|
this is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this.showsUpdated.remove(id)inBatch.prototype.removefor bothStaticGroundPolylinePerMaterialBatchandStaticGroundGeometryPerMaterialBatchisShowingproperty changes and the entity is removed before the next render,updateShowsiterates a stale entry, callsthis.geometry.get(updater.id)on a removed entity, and crashes withCannot read properties of undefined (reading 'id')Issue number and link
#9370
Testing plan
StaticGroundPolylinePerMaterialBatchSpectests passStaticGroundGeometryPerMaterialBatchSpectests passentity.show, then remove entity before next frame — no crashAuthor checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):