Skip to content

Clean up voxel shape transforms#13375

Open
jjhembd wants to merge 2 commits intomainfrom
voxel-scale-default
Open

Clean up voxel shape transforms#13375
jjhembd wants to merge 2 commits intomainfrom
voxel-scale-default

Conversation

@jjhembd
Copy link
Copy Markdown
Contributor

@jjhembd jjhembd commented Apr 7, 2026

Description

This PR cleans up some internal transforms for voxel shape bounds.

The VoxelShape classes had separate vec2 uniforms for the bounds along each dimension, each uniform containing a scale and a translation. However, since #12933, the translation was not used in the shader. This PR combines the 3 scalars into a single vec3 uniform.

A few inline comments were added to clarify some of the bounds transform calculations.

Issue number and link

Resolves #12782.

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

AI acknowledgment

  • I used AI to generate content in this PR
  • If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

GitHub Copilot

If yes, I used the following Model(s):

Claude Sonnet 4

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Thank you for the pull request, @jjhembd!

✅ We can confirm we have a CLA on file for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading scale/offset defaults in voxel shapes

1 participant