Draft
Conversation
Contributor
|
Thank you for the pull request, @mzschwartz5! ✅ We can confirm we have a CLA on file for you. |
mzschwartz5
commented
Apr 13, 2026
Comment on lines
+137
to
+149
| const workspaceEntryPoints = { | ||
| engine: path.join(projectRoot, "packages/engine/index.js"), | ||
| edit: path.join(projectRoot, "packages/edit/index.js"), | ||
| widgets: path.join(projectRoot, "packages/widgets/index.js"), | ||
| }; | ||
|
|
||
| const workspaceAliases = Object.fromEntries( | ||
| Object.entries(workspaceEntryPoints).map(([workspace, entryPoint]) => [ | ||
| `@${scope}/${workspace}`, | ||
| entryPoint, | ||
| ]), | ||
| ); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is something AI suggested. Basically, I believe the idea is that instead of resolving imports through node_modules during bundling, it rewrites the import to resolve to the local workspace under the correct package. This is supposedly less brittle because it doesn't depend on things all being installed first.
I'm no expert here so that's why I'm pointing it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
=== DO NOT MERGE ===
Followed #13400
Adds a new npm package, 'edit', for upcoming mesh editor capabilities.
Issue number and link
#13398
Testing plan
Make sure everything builds independently and together.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):