Remove feature flags app#71
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 45.69% 45.31% -0.39%
==========================================
Files 45 42 -3
Lines 3208 3145 -63
Branches 332 332
==========================================
- Hits 1466 1425 -41
+ Misses 1722 1700 -22
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def playlist_updates() -> None: | ||
| if PLAYLIST_UPDATES_SCHEDULE is None: | ||
| raise RuntimeError("playlist_updates schedule is not set") | ||
| schedule = settings.SCHEDULE.get("PLAYLIST_UPDATES") | ||
| if schedule is None: | ||
| logger.warning("PLAYLIST_UPDATES schedule is not set. Skipping task creation") | ||
| return |
There was a problem hiding this comment.
Both schedule helpers now return early when settings.SCHEDULE[...] is None. Because SCHEDULE_PLAYLIST_UPDATES/SCHEDULE_EVENT_UPDATES default to None (settings.py lines 313-315) and neither compose files nor .env define them, starting the taskrunner will hit this branch and skip creating the django-q schedules, so playlist and event updates never run. Previously the absence of a schedule raised and failed startup; now the job setup silently disappears whenever those env vars are unset.
Useful? React with 👍 / 👎.
1 participant
No description provided.