fix: Auto-register unregistered players instead of producing errors#41
Merged
fix: Auto-register unregistered players instead of producing errors#41
Conversation
Players missing from players.json now get automatically created (level 0, 0 XP) on the fly instead of failing with cryptic errors or silently cancelling events. Adds MiningPlayer.getOrCreateMiningPlayer() and updates all call sites. Bumps version to 1.3.1 and CrucialLib to 3.0.1. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MiningPlayer.getOrCreateMiningPlayer(UUID)that returns an existing player or creates a new one (level 0, 0 XP) on the flygetMiningPlayer()+ null-check-with-error patterns across 8 files with the new auto-registering methoddocs/installation.mdTest plan
players.json, have them mine a block — they should be auto-registered instead of getting an error/ml self,/miningrewards, and PlaceholderAPI placeholders work for a previously unregistered player🤖 Generated with Claude Code