Fix flywheel velocity naming conventions in ShooterSetpoint - #3
Open
jovapo wants to merge 1 commit into
Open
Conversation
ShooterSetpoint stored flywheel speed as LinearVelocity (flywheelSurfaceSpeed) but the LUT values are rotations per second. Renamed to AngularVelocity (flywheelVelocity) so the type matches the actual unit. No change to real robot behavior. Also updates sim LUT to use real values and corrects the sim projectile speed conversion to use proper RPS->m/s math.
jovapo
force-pushed
the
fix/shooter-velocity-units
branch
from
March 3, 2026 03:40
1b628e4 to
bb35dbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShooterSetpointfield renamed fromflywheelSurfaceSpeed: LinearVelocitytoflywheelVelocity: AngularVelocity— the LUT values are RPS, not m/s, so the type and name now match the actual unittargetLinearVelocity()renamed totargetFlywheelVelocity()for the same reasonrunShooterControl()Sim fixes
convertAngularVelocityToLinear()before applyingkEstimatedFlywheelSpeedToFuelSpeedkEstimatedFlywheelSpeedToFuelSpeedtuned from 0.3 → 0.33 to better match observed sim trajectoriesTest plan