This repository was archived by the owner on Jul 22, 2026. It is now read-only.
fix: in order for the isPubSub function to work with gossipsub this is mandatory - #512
Open
sfroment wants to merge 2 commits into
Open
fix: in order for the isPubSub function to work with gossipsub this is mandatory#512sfroment wants to merge 2 commits into
sfroment wants to merge 2 commits into
Conversation
…s mandatory Signed-off-by: Sacha Froment <sfroment42@gmail.com>
3 tasks
achingbrain
previously approved these changes
Jan 13, 2025
Collaborator
|
Small nit but it might be worth adding a test that asserts instances of |
Author
|
Will add and won't forget such stuff in the future 🙏 |
Signed-off-by: Sacha Froment <sfroment42@gmail.com>
achingbrain
approved these changes
Feb 6, 2025
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sacha Froment sfroment42@gmail.com