You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
make sure all mev sidecars support 415 status code to fall back to JSON or add custom retry mechanism
forward bytes submitted through registerValidator beacon api to skip extra serialization step cannot be done right now since we are filtering registrations here so forwarding raw SSZ bytes is not an option and extra work is likely not worth it as serialization is cheap anyways when using SSZ
(TODO) make sure all mev sidecars support 415 status code to fall back to JSON or add custom retry mechanism
I guess we're assuming that all mev sidecars support the latest beacon API as of electra release?
still cautions with merging this one, the builder spec has ssz support for the api but the problem is that mev-boost just passes those requests through to relay, so it's actually the relay that needs to support ssz or respond with 415, I haven't validated this yet on any public network, and there was also a bug in some relays.. imo should hold off merging this for a bit, marked it as ready for review as PR itself is ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See ethereum/builder-specs#110
Description
Send validator registrations to builder using SSZ
TODO
forward bytes submitted through registerValidator beacon api to skip extra serialization stepcannot be done right now since we are filtering registrations here so forwarding raw SSZ bytes is not an option and extra work is likely not worth it as serialization is cheap anyways when using SSZCloses #7369