Skip to content

chore: export builder id route type - #9614

Merged
nflaig merged 1 commit into
ChainSafe:nflaig/state-builders-apifrom
lodekeeper:fix/pr9593-builder-id
Jul 7, 2026
Merged

chore: export builder id route type#9614
nflaig merged 1 commit into
ChainSafe:nflaig/state-builders-apifrom
lodekeeper:fix/pr9593-builder-id

Conversation

@lodekeeper

Copy link
Copy Markdown
Contributor

Addresses review feedback on #9593 by exporting a dedicated BuilderId route type and using it for builder state lookups instead of ValidatorId.\n\nVerification:\n- pnpm lint\n- pnpm build\n- pnpm check-types

@lodekeeper
lodekeeper requested a review from a team as a code owner July 7, 2026 10:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new BuilderId type (defined as string | number) and updates the beacon state routes and utility functions to use BuilderId instead of ValidatorId for builder-related identifiers. This improves type safety and clarity by distinguishing builders from validators. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@markolazic01

Copy link
Copy Markdown
Contributor

Looks good : )

@nflaig
nflaig merged commit ddc9748 into ChainSafe:nflaig/state-builders-api Jul 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants