Skip to content

chore: alias builder id serdes helpers - #9618

Merged
nflaig merged 1 commit into
ChainSafe:nflaig/state-builders-apifrom
lodekeeper:fix/pr9593-builder-id-serdes-aliases
Jul 7, 2026
Merged

chore: alias builder id serdes helpers#9618
nflaig merged 1 commit into
ChainSafe:nflaig/state-builders-apifrom
lodekeeper:fix/pr9593-builder-id-serdes-aliases

Conversation

@lodekeeper

@lodekeeper lodekeeper commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Addresses review feedback on #9593 by adding explicit builder ID serdes aliases while preserving existing validator helper names for validator call sites.

Changes:

  • Add toBuilderIdsStr / fromBuilderIdsStr aliases in API serdes
  • Use the builder aliases for getStateBuilders request serialization/parsing

Verification:

  • pnpm lint
  • pnpm build
  • pnpm check-types

@lodekeeper
lodekeeper requested a review from a team as a code owner July 7, 2026 10:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces toBuilderIdsStr and fromBuilderIdsStr as aliases for toValidatorIdsStr and fromValidatorIdsStr in packages/api/src/utils/serdes.ts. It then updates the state route definitions in packages/api/src/beacon/routes/beacon/state.ts to use these new builder-specific serialization and deserialization functions instead of the validator-specific ones. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@nflaig
nflaig merged commit 44603ee into ChainSafe:nflaig/state-builders-api Jul 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants