perf: improve process_attestation() for gloas#9664
Open
twoeths wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors getAttestationParticipationStatus to return both flags and isSameSlotAttestation, allowing the removal of the isAttestationSameSlot function and avoiding redundant state root lookups. Feedback suggests further optimizing this hot path by caching and reusing the isMatchingBlockRoot computation to avoid duplicate byteArrayEquals and isAttestationSameSlotRootCache calls.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The gloas is_attestation_same_slot implementation was renamed to isAttestationSameSlotRootCache; point the ethspecify search string at the new name so the spec-refs check passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9664 +/- ##
=========================================
Coverage 52.49% 52.50%
=========================================
Files 848 848
Lines 60485 60480 -5
Branches 4466 4466
=========================================
- Hits 31754 31753 -1
+ Misses 28670 28666 -4
Partials 61 61 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a56aba338c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| rootCache: RootCache, | ||
| executionPayloadAvailability: BitArray | null | ||
| ): number { | ||
| ): {flags: number; isSameSlotAttestation: boolean} { |
There was a problem hiding this comment.
This function is exported from the package root (src/index.ts), so changing it from returning the participation bitfield to returning an object is a breaking runtime change for consumers that do const flags = getAttestationParticipationStatus(...) and then apply bitwise checks; in JavaScript, flags & TIMELY_SOURCE on this object evaluates as 0, silently dropping all rewards/flags. Please keep the public function returning the numeric flags and add a separate helper/option for the same-slot boolean.
Useful? React with 👍 / 👎.
| /** | ||
| * Use cached block roots to avoid repeated state root lookups while matching the spec's is_attestation_same_slot behavior. | ||
| */ | ||
| export function isAttestationSameSlotRootCache(rootCache: RootCache, data: AttestationData): boolean { |
There was a problem hiding this comment.
Renaming the exported isAttestationSameSlot helper removes it from @lodestar/state-transition because util/index.ts re-exports gloas.ts and the root index re-exports util; downstream users importing the spec-shaped helper will fail at module/type resolution even though this perf change only needs an additional RootCache-based variant internally. Please retain a compatibility wrapper with the original name/signature while using the cached helper in the hot path.
Useful? React with 👍 / 👎.
ensi321
approved these changes
Jul 18, 2026
ensi321
left a comment
ensi321
left a comment
Member
There was a problem hiding this comment.
looks good. no comment to add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
glamsterdam-devnet-7by panda tool, hope this fixes itDescription
isAttestationSameSlotRootCache()once per block transitionAI Assistance Disclosure