fix!: manage external buffer lifetime - #66
Open
GrapeBaBa wants to merge 5 commits into
Open
Conversation
GrapeBaBa
marked this pull request as ready for review
July 28, 2026 13:04
nazarhussain
approved these changes
Jul 28, 2026
Contributor
|
This has good test coverage for that tricky case. @GrapeBaBa Good work 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
.external_bufferreturn hint passed borrowed Zig slices to JavaScript without copying or registering a finalizer. JavaScript can retain the Buffer after the native callback returns, leaving it backed by stack, arena, or otherwise freed memory. External buffers should retain their zero-copy behavior while making ownership and cleanup explicit.Description
OwnedBufferthat transfers its allocation to JavaScript..external_buffercallbacks to returnOwnedBuffer; ordinary byte-slice returns continue to copy.OwnedBuffer; environments that disallow external buffers copy the bytes and release the original allocation, while other errors preserve ownership already accepted by the N-API finalizer.--expose-gcintegration test that verifies the external data and finalizer context remain live while reachable and are both released after GC.