FIRE: fix: revision_count should not include revisions that do not correspond to an edit#244
Open
double-beep wants to merge 1 commit intoCharcoal-SE:masterfrom
Open
Conversation
…correspond to an edit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally, SD reports community wiki posts, or questions that are closed minutes after they are reported. FIRE considers these as "edited", even though they haven't been edited, due to the fact that events like bounties and CW/close notices are treated as new revisions by the SE API.
This PR excludes revisions that do not correspond to an edit from being counted in
revision_count, which determines whether the pencil icon will appear in the FIRE popup.See also: Type revision from the SE API docs.