Stabilize authentication modal behavior and improve auth flow consistency#472
Open
lucifers-0666 wants to merge 2 commits into
Open
Stabilize authentication modal behavior and improve auth flow consistency#472lucifers-0666 wants to merge 2 commits into
lucifers-0666 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleaned up and stabilized the authentication modal system to remove conflicting logic and improve consistency across login/signup flows.
Changes Made
index.html#auth-modalelement — removed all duplicate markupstyle="display:..."toggles from the auth modal element.auth-modal-hiddenimmediately on confirmed session, preventing flicker<script>block; removed leftover logic scattered across multiple inline scripts<button id="add-btn">— only one now exists in the panelstyle.display(intentional — it is not auth, unrelated to this PR)css/index.css:rootblock and all duplicated rule sets — the file previously contained the entire stylesheet twice, causing constant cascade conflictsbody.auth-open { overflow: hidden; }for scroll lock.app.auth-blurred { filter: blur(2px); pointer-events: none; user-select: none; }for dashboard visual recession.app { transition: filter 0.2s ease; }for smooth blur in/out--auth-accentand--auth-accent-focus-ringCSS variables for the auth modal's indigo accent, isolated from the main palette.auth-modal-overlay,.auth-modal-hidden,.auth-modal-cardstyles — single source of truth, no conflicts@keyframes auth-modal-infor entry animation:root[data-theme="light"]and:root[data-theme="dark"]overrides to support the settings toggle correctly.toggle-switch/.toggle-sliderstyles for the settings dark-mode togglejs/app.jsapp.js— correctly left untouched<script>block inindex.htmlVisibility Strategy
One strategy only — class-based:
No
style.displaymixed in. Nohiddenattribute. No opacity hacks.Testing Checklist
pointer-events: none)overflow: hidden)/api/auth/login, stores session)showAuthModal()on click)Fixes #450