This repository was archived by the owner on Jun 30, 2025. It is now read-only.
fix don't report unactionable w3name request errors to Sentry#652
Merged
juliangruber merged 3 commits intomainfrom Dec 18, 2024
Merged
fix don't report unactionable w3name request errors to Sentry#652juliangruber merged 3 commits intomainfrom
juliangruber merged 3 commits intomainfrom
Conversation
pyropy
approved these changes
Dec 17, 2024
Member
pyropy
left a comment
pyropy
left a comment
There was a problem hiding this comment.
Changes look good! I wonder if we'd have any benefits of keeping metrics on how often are these errors happening?
Member
That's what I was thinking too! |
bajtos
approved these changes
Dec 17, 2024
pyropy
reviewed
Dec 18, 2024
Member
Author
|
I hadn't yet set up commit signing on this machine, all future commits will be signed |
Signed-off-by: Julian Gruber <julian@juliangruber.com>
Signed-off-by: Julian Gruber <julian@juliangruber.com>
juliangruber
force-pushed
the
fix/silence-w3name-sentry
branch
from
449fe8d to
71eb89e
Compare
Member
Author
|
Also added to Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://filecoinproject.slack.com/archives/C06SFMDMUAU/p1734275910797789
Related: #651